Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renepay refactor #7588

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

Lagrang3
Copy link
Collaborator

Instead of a global variable for plugin data, retrieve plugin data using
libplugin API plugin_get_data.

builds on top of #7574.

In theory we should not have htlc_total<=known_max.
But for some strange race condition we do sometimes.
Until we find a solution to ensure the correct state
of the uncertainty network we remove the assertion.
Thanks to signed arithmetic and MIN guards, the rest
of the code in linearize_channel can handle the
weird cases with known_max<htlc_total.

Signed-off-by: Lagrang3 <[email protected]>
- add more checks
- add more error messages
- compute probabilities without fees during MCF
- compute probabilities with fees during get_routes

Signed-off-by: Lagrang3 <[email protected]>
Instead of a global variable for plugin data, retrieve plugin data using
libplugin API plugin_get_data.

Signed-off-by: Lagrang3 <[email protected]>
@Lagrang3 Lagrang3 added this to the v24.11 milestone Aug 16, 2024
@Lagrang3 Lagrang3 marked this pull request as draft August 17, 2024 10:07
@rustyrussell
Copy link
Contributor

This is draft, so removing milestone

@rustyrussell rustyrussell removed this from the v24.11 milestone Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants