Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #40 #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Issue #40 #41

wants to merge 1 commit into from

Conversation

daniel-moya
Copy link

@daniel-moya daniel-moya commented Oct 18, 2019

Bump gulp-sass from 2.3.2 to 3.0.0 😄 (This Fix Issue #40)

Error when making npm install

I solved this by changing in package.json:
"gulp-sass": "^2.3.2"
to
"gulp-sass": "3.0.0",

codecombat/codecombat#4430 (comment)

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\yrrod_000\AppData\Roaming\npm-cache\_logs\2019-10-18T09_03_25_525Z-debug.log

Bump gulp-sass from 2.3.2 to 3.0.0
@daniel-moya daniel-moya marked this pull request as ready for review October 18, 2019 09:15
@hhaoao
Copy link

hhaoao commented Jan 25, 2020

@damr67 Hello, your PR didn't completely solve the dependency problem, I found that the #36 has been perfectly solved, just did not merge into the master branch.

I find that many people don't find that the problem has been solved, and I'm here to write down how to fetch an inactive request pull, hoping to help those in need.

git clone https://github.com/EmailThis/extension-boilerplate.git
cd .\extension-boilerplate\
git fetch origin pull/36/head:genietim
git merge genietim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants