Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy/docker images #278

Closed
wants to merge 11 commits into from
Closed

Deploy/docker images #278

wants to merge 11 commits into from

Conversation

Delyc
Copy link
Contributor

@Delyc Delyc commented Sep 24, 2024

Brief summary of the change made

  • Moved the frontend Dockerfile from the 'UI' folder to the 'Docker' directory where all images are stored.
  • Added workflows for deploying both frontend and backend production Dockerfiles to Docker Hub.

Are there any other side effects of this change that we should be aware of?

None

Describe how you tested your changes?

  • Ran the Docker image locally

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@dmohns
Copy link
Member

dmohns commented Sep 24, 2024

Hey @Delyc

could you please keep it to one change per PR? You are doing many things here 🙈

  • First of all, please make sure to properly rebase on your other branches, so you don't pull in old changes.
  • Please create a new PR for moving the development docker file

Regarding the CI/CD:
Please be careful with pushing to Dockerhub ⚠️ Currently, you are trying to push on every commit.

on:
  push:
    branches:
      - deploy/docker-images

This should be triggered by creation of a release, not by branch.

@Delyc Delyc closed this Sep 30, 2024
@dmohns dmohns mentioned this pull request Oct 21, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants