Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code with phpstan warning #248 #398

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

beesaferoot
Copy link
Contributor

@beesaferoot beesaferoot commented Dec 7, 2024

- Updated existing code using phpstan suggestions
- added missing code where needed
- deleted unused code/comments

Brief summary of the change made

Makes progress on: #248

This PR fixes some PHPStan warnings/errors. However, there are still about 18 such errors left.

Remaining errors are more tricky due to references to missing models or table fields.

Screenshot 2024-12-07 at 10 08 43 AM

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

    - Updated existing code using phpstan suggestions
    - added missing code where needed
    - deleted unused code/comments
@beesaferoot beesaferoot requested a review from dmohns December 7, 2024 09:09
Copy link
Member

@dmohns dmohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks a lot!

Yeah, for the remaining ones, we need to go case-by-case to understand where they are coming from. They probably relate to some in-proper refactoring that was done in the past.

@dmohns dmohns merged commit 62ad09d into EnAccess:main Dec 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants