Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix new target page endpoint #124 #450

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

beesaferoot
Copy link
Contributor

@beesaferoot beesaferoot commented Dec 22, 2024

Brief summary of the change made

Created a missing endpoint needed to get the count of connection types /api/meters/parameters/connection-types

now /api/meters/connection-types

Closes #124

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Steps to test:

  • Login to the dashboard
  • Navigate to Target section
  • Confirm no server error on the page using the browser network tab

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@munyanezaarmel
Copy link
Contributor

@beesaferoot, if possible, could you add a simple description of how you tested your changes and how we can test them to ensure we are on the same page?

@beesaferoot
Copy link
Contributor Author

@munyanezaarmel Added few steps to test. Thanks

@munyanezaarmel
Copy link
Contributor

@beesaferoot I don't see errors. resolve conflicts

@beesaferoot beesaferoot force-pushed the fix-routing-error-new-target branch from f4ab2b7 to 3048524 Compare December 23, 2024 09:35
@beesaferoot
Copy link
Contributor Author

Ready for review @munyanezaarmel

@beesaferoot beesaferoot force-pushed the fix-routing-error-new-target branch from 3048524 to 7c398e0 Compare December 30, 2024 10:03
@beesaferoot beesaferoot merged commit 3b39b40 into main Dec 30, 2024
11 checks passed
@beesaferoot beesaferoot deleted the fix-routing-error-new-target branch December 30, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Routing error in Targets New
2 participants