Remove references to bing map #259 #451
Conversation
- Removes BingMapService (backend) - Removes bingMapKey field in MapSettings model - Removes front reference to bing map Key
| $table->string('provider')->nullable(); | ||
| $table->string('bingMapApiKey')->nullable(); | ||
| $table->timestamps(); |
There was a problem hiding this comment.
Generally, I'm not a fan of changing migration files retrospectively.
This will create confusion in the long run. For example, this change (i.e. the removal of column bingMapApiKey) will not be applied to existing instances of MPM. Only new instances will have the column removed.
I think it's always better to create a new migration file for this, this also allows us to roll back changes if need be.
Could you send a new PR that restores this file and create a new migration to remove the column? You can use php artisan make:migration-tenant to get a template of the migration.
`
There was a problem hiding this comment.
I went with the assumption there will be breaking changes that require us to do a fresh migration. Not a good approach, I must admit.
Could you send a new PR that restores this file and create a new migration to remove the column? You can use php artisan make:migration-tenant to get a template of the migration.
I will apply a new migration accordingly, thanks.
Brief summary of the change made
Partially closes #259
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.