Fix failures in barman-cloud-backup-delete related with incrementals
#1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Through Barman 3.11.0 we introduced native PG17+ incremental backups. Some changes have been made to the backup metadata to support that. As part of the changes, we introduced a few properties to the class `LocalBackupInfo`. However, there was an oversight in some code paths which are shared between local and cloud backups. For example, when running `barman-cloud-backup-delete`, that command reuses the retention policy classes. These, in their turn, attempt to access the aforementioned properties. This commit fixes the issue by moving the new properties to the base `BackupInfo` class, so they are available both for local and for cloud backups. The properties `has_children` and `is_incremental` will always return `False` for cloud backups. Analagously, `deduplication_ratio` and `backup_type` are not expected to be used in any code path related with cloud backups. With that in mind, moving these properties to the base classe should not cause a problem. References: BAR-284. Signed-off-by: Israel Barth Rubio <[email protected]>
andremagui
approved these changes
Aug 22, 2024
|
We have no CODEOWNER available right now, but we agreed on a call earlier today that we would merge this PR and proceed with a patch release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through Barman 3.11.0 we introduced native PG17+ incremental backups. Some changes have been made to the backup metadata to support that.
As part of the changes, we introduced a few properties to the class
LocalBackupInfo. However, there was an oversight in some code paths which are shared between local and cloud backups.For example, when running
barman-cloud-backup-delete, that command reuses the retention policy classes. These, in their turn, attempt to access the aforementioned properties.This commit fixes the issue by moving the new properties to the base
BackupInfoclass, so they are available both for local and for cloud backups.The properties
has_childrenandis_incrementalwill always returnFalsefor cloud backups. Analagously,deduplication_ratioandbackup_typeare not expected to be used in any code path related with cloud backups. With that in mind, moving these properties to the base classe should not cause a problem.References: BAR-284.