Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add super linter to Barman #1017

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add super linter to Barman #1017

merged 1 commit into from
Sep 19, 2024

Conversation

andremagui
Copy link
Contributor

This PR is

  • Adding the linter.yml workflow to the barman repository
  • Adding the files that are referenced in the workflow
    • .gitleaks.toml
    • .hadolint.yaml
    • .isort.cfg
    • .markdownlint.yml
    • .python-black
    • .yamllint.yml

References: BAR-361

@andremagui
Add super linter to barman
4d2e8e9 
This commit:

* Adds the `linter.yml` workflow to this repo
* Adds the files that are referenced in the workflow
        * .gitleaks.toml
        * .hadolint.yaml
        * .isort.cfg
        * .markdownlint.yml
        * .python-black
        * .yamllint.yml

References: BAR-361

Signed-off-by: Andre <[email protected]>
@andremagui andremagui force-pushed the dev/bar-361 branch 2 times, most recently from 50a1eb5 to 31ebbf3 Compare September 18, 2024 21:21
@andremagui andremagui marked this pull request as ready for review September 18, 2024 21:21
@andremagui andremagui requested a review from a team as a code owner September 18, 2024 21:21
martinmarques
martinmarques reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@martinmarques martinmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the YAML and Markdown linters? I don't think we have .yml files in the public repo, and for Markdown, we are moving to structured text

@barthisrael barthisrael changed the title "Copy" super linter from internal to barman public repo Add super linter to Barman Sep 19, 2024
barthisrael
barthisrael requested changes Sep 19, 2024
View reviewed changes
.github/workflows/linter.yml Outdated Show resolved Hide resolved
.github/workflows/linter.yml Outdated Show resolved Hide resolved
@barthisrael
Copy link
Contributor

Do we need the YAML and Markdown linters? I don't think we have .yml files in the public repo, and for Markdown, we are moving to structured text

We have YAML files under .github, and MD files in the repo root.
I think we can keep those, although it's less likely that we would change those files here.

@andremagui andremagui merged commit 7c7385e into master Sep 19, 2024
10 checks passed
@andremagui andremagui deleted the dev/bar-361 branch September 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barthisrael barthisrael barthisrael approved these changes

@martinmarques martinmarques Awaiting requested review from martinmarques

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andremagui @barthisrael @martinmarques