Use isoformat for dates when producing json output in cloud commands #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcalacoci
force-pushed
the
dev/bar-316
branch
from
b3376a2 to
7689add
Compare
barthisrael
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
From what I can see, the begin_time and end_time are always set with a time zone. With that in mind, I think we can simply proceed they way you are doing, i.e. replacing ctime with isoformat.
The changes look good.
As a side comment, I was wondering if we should take the opportunity to add unit tests for barman-cloud-backup-list with JSON output? Currently we have only for console mode.
This patch modifies the `to_json()` method of the BackupInfo class substituting the `ctime` method from the datetime class with the `isoformat` method, when printing `begin_time` and `end_time` in json format. The new format preserves all the relevant informations of the datetime object, including the timezone. References: bar-316 Signed-off-by: Giulio Calacoci <[email protected]>
References: bar-316 Signed-off-by: Giulio Calacoci <[email protected]>
gcalacoci
force-pushed
the
dev/bar-316
branch
from
7689add to
adbd733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch modifies the
to_json()method of the BackupInfo classsubstituting the
ctimemethod from the datetime class with theisoformatmethod, when printingbegin_timeandend_timein json format.
The new format preserves all the relevant informations of the datetime
object, including the timezone.
References: bar-316