Proof of concept fix for barman backup --wait on pg17
#1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pg_walfile_name_offset() has been changed in pg17 to return the current segment if on a segment boundary. Implement previous_segment_name() to calulate the previous segment and use this to restore the pre pg17 behaviour. Tested with pg16 and pg17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pg_walfile_name_offset() has been changed in pg17 to return the current segment if on a segment boundary.
Implement previous_segment_name() to calulate the previous segment and use this to restore the pre pg17 behaviour.
Tested with pg16 and pg17.