allow set-version to build doc with docker image #842

didiermichel · 2023-09-12T06:59:55Z

Changed set-version.sh behavior.

Instead of positional argument it uses flags.
before:
set-version.sh 3.5.0 20231206
now:

set-version.sh -r 3.5.0 -d 20231206 (identical)
set-version.sh -r 3.5.0 -d 20231206 -D (using docker image)
set-version.sh -r 3.5.0 -D (uses docker image and current date)

Updated release process documentation in Source code changes section.

gcalacoci · 2023-09-12T08:16:58Z

doc/Makefile

@@ -69,6 +69,12 @@ clean:
 		$(MAKE) -C $$dir clean; \
 	done

+build-image:
+	docker build . -t ghcr.io/enterprisedb/barman/barman-pandoc:master


maybe i'm wrong, but ghcr.io/enterprisedb images are not public, not sure this should be on an open-source project... as this will not work for someone that is not part of EDB

As long as you do not try to pull or push an image from the ghcr.io/enterprisedb registry, you can use it.
So it should be usable as it is.
I also admit that it may be confusing, and maybe not a good practice to share internal things such as a docker image.

So I could either keep it that way or rename it.
What do you think?

I don't remember what is inside the internal image, maybe we can make the image public? I think so but not sure yet.

Docker file is here,:https://github.com/EnterpriseDB/barman/blob/master/doc/Dockerfile
I believe it has nothing that requires being internal.

gcalacoci · 2023-09-12T08:17:25Z

doc/Makefile

+	docker build . -t ghcr.io/enterprisedb/barman/barman-pandoc:master
+
+create-all:
+	docker run --rm --volume "`pwd`:/data" -w="/data" --user `id -u`:`id -g` ghcr.io/enterprisedb/barman/barman-pandoc:master make clean all
