BAR-113: Add --min-chunk-size option to barman-cloud-backup #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewallace1979
commented
Sep 27, 2023
.github/recover_process.png
Outdated
There was a problem hiding this comment.
Not quite sure how I managed to add this to the PR - it wasn't intentional.
Adds a new option, `--min-chunk-size`, to `barman-cloud-backup`. If set then this will be used when setting the minimum size of an upload chunk in a multipart upload. The only guarantee Barman offers here is that the upload chunk size will be greater than this value - the actual chunk size used will be whichver is greatest of: `--min-chunk-size`, the `MIN_CHUNK_SIZE` for the cloud provider, or the calculated chunk size based on the `max_archive_size` and the `MAX_CHUNKS_PER_FILE` property of the cloud interface. This can be used to ensure uploaded chunks are not smaller than the specified value. Relates to BAR-113.
Rather than test the `--min-chunk-size` against the calculated chunk size in one place and then test the result against the cloud interface `MIN_CHUNK_SIZE` in another, we peform all `chunk_size` setting checks in the `CloudUploadController` and update `CloudTarUploader` so that it is just given the chunk size by the upload controller. Relates to BAR-113.
Updates the unit tests for the `CloudBackupUploader` creation such that they validate that both `--max-archive-size` and the new `--min-chunk-size` options are passed to the `CloudBackupUploader`. Relates to BAR-113.
Update tests so that chunk_size is now passed to CloudTarUploader instead of being read from the cloud interface. Relates to BAR-113.
Adds tests for ClourUploadController which verify that it computes the correct max_archive_size and chunk_size given the supplied arguments and cloud interface properties. Relates to BAR-113.
mikewallace1979
force-pushed
the
bar-113-option-for-min-chunk-size-in-barman-cloud
branch
from
c03d615 to
83f6951
Compare
|
SonarQube Quality Gate
|
mikewallace1979
deleted the
bar-113-option-for-min-chunk-size-in-barman-cloud
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.