chore: avoid blocking base image update #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnencia
approved these changes
Nov 27, 2024
If there's a package discrepancy we were avoiding updating the base image, now we update even if there's a discrepancy Signed-off-by: Jonathan Gonzalez V. <[email protected]>
Signed-off-by: Niccolò Fei <[email protected]>
mnencia
force-pushed
the
dev/cnp-5644
branch
from
0022ffb to
1836b04
Compare
|
I think we should have the update in a separate patch. We should remove it before merging. |
NiccoloFei
force-pushed
the
dev/cnp-5644
branch
2 times, most recently
from
5c092fd to
df55013
Compare
Signed-off-by: Niccolò Fei <[email protected]>
NiccoloFei
force-pushed
the
dev/cnp-5644
branch
from
df55013 to
e971115
Compare
NiccoloFei
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there's a package discrepancy we were avoiding updating the base image, now we update even if there's a discrepancy