Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TDE: tutorials to enable data wrapper and provide passphrase in file #6351

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

gvasquezvargas
Copy link
Contributor

@gvasquezvargas gvasquezvargas commented Dec 12, 2024

What Changed?

https://enterprisedb.atlassian.net/browse/DOCS-1147

All feedback related to the streamlining of documentation was already introduced in #6342

This PR focuses on introducing a new tutorial for enabling key wrapping and a section for assigning a passphrase as a key wrapper via file.

@gvasquezvargas gvasquezvargas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Dec 12, 2024
@gvasquezvargas gvasquezvargas requested a review from a team as a code owner December 12, 2024 22:20
@gvasquezvargas gvasquezvargas marked this pull request as draft December 12, 2024 22:20
Copy link
Contributor

github-actions bot commented Dec 12, 2024

@github-actions github-actions bot temporarily deployed to pr-6351-tde-add_wrapper_tutorial December 12, 2024 22:30 Inactive
@github-actions github-actions bot temporarily deployed to pr-6351-tde-add_wrapper_tutorial December 16, 2024 16:02 Inactive
@github-actions github-actions bot temporarily deployed to pr-6351-tde-add_wrapper_tutorial December 16, 2024 17:36 Inactive
@github-actions github-actions bot temporarily deployed to pr-6351-tde-add_wrapper_tutorial December 16, 2024 19:58 Inactive
@gvasquezvargas gvasquezvargas marked this pull request as ready for review December 16, 2024 21:32
@gvasquezvargas gvasquezvargas changed the title TDE: tutorial to enable data wrapper TDE: tutorials to enable data wrapper and provide passphrase in file Dec 16, 2024
@theadamwright theadamwright self-requested a review December 16, 2024 23:16
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - small expansion on demo and a warning on a warning in comments.


!!!note
If you want to enable key wrapping on TDE-enabled database clusters where key wrapping was previously disabled, see [Enabling a mechanism to protect the data encryption key](../enabling/enabling_key_wrapper).
!!!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an admonition warning here because I think the actual content of the note above is indented and that makes it unfenced and then the checker sees a !!! after it and that looks like the start of another admonition. Not an issue on this pass but if text is added after this, it may light up as an admonition.

product_docs/docs/tde/15/secure_key/passphrase.mdx Outdated Show resolved Hide resolved
product_docs/docs/tde/15/enabling/enabling_key_wrapper.mdx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants