Catch output variation for recent MariaDB server changes #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariaDB 10.5 prints "Unknown server host" instead of "Unknown MySQL server host". We are already normalizing the error message in tests, accept that form as well. Regression diff observed was: -NOTICE: failed to connect to MySQL: Unknown MySQL server host 'localhos' +NOTICE: failed to connect to MySQL: Unknown server host 'localhos' (-2)
|
Hi, Can you please share the exact MariaDB version? |
|
The string is from mariadb 10.5.12 there: Failing build log: |
|
I am not sure whether that error is version-specific or not because I am not able to see regression diff at my end against MariaDB 10.5.13 on CentOS 7. However, your suggested change make sense to me as your facing this issue at your end. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MariaDB 10.5 prints "Unknown server host" instead of "Unknown MySQL server host".
We are already normalizing the error message in tests, accept that form as well.
Regression diff observed was:
-NOTICE: failed to connect to MySQL: Unknown MySQL server host 'localhos'
+NOTICE: failed to connect to MySQL: Unknown server host 'localhos' (-2)