Made rewards_apy_percentage configurable up to 2 decimal places. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supra-yoga
approved these changes
Oct 8, 2024
sjoshisupra
reviewed
Oct 9, 2024
| genesis_config.rewards_apy_percentage > 0 && genesis_config.rewards_apy_percentage < 100, | ||
| "Rewards APY must be > 0% and < 100%" | ||
| genesis_config.rewards_apy_percentage > 0 && genesis_config.rewards_apy_percentage < APY_PRECISION, | ||
| "Rewards APY must between >= 1 (i.e. 0.01%) and < 10,000 (i.e. 100%)" |
There was a problem hiding this comment.
@isaacdoidge , I am confused, if we need precision for 3 decimal places, shouldn't 1 mean 0.001% and 100000 should be 100%?
| @@ -88,6 +90,8 @@ pub struct GenesisConfiguration { | |||
| pub min_voting_threshold: u64, | |||
| pub recurring_lockup_duration_secs: u64, | |||
| pub required_proposer_stake: u64, | |||
| // The APY rewards rate specified as a percentage plus 3 decimals of precision. | |||
There was a problem hiding this comment.
It says 3 decimal precision here but at other places I see values of 1000 for 10%. @isaacdoidge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #105.