fix: patch __spreadArray helper to work around tslib bug (#4481) #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
benelan
reviewed
May 18, 2022
| @@ -48,6 +48,7 @@ | |||
| "util:copy-icons": "cpy \"./node_modules/@esri/calcite-ui-icons/js/*.json\" \"./src/components/icon/assets/icon/\" --flat", | |||
| "util:deploy-next": "npm run util:prep-next && npm run util:push-tags && npm run util:publish-next", | |||
| "util:deploy-next-from-ci": "ts-node --project ./tsconfig-node-scripts.json support/deployNextFromCI.ts", | |||
| "util:patch-es5-helpers": "ts-node support/patchES5Helpers.ts", | |||
There was a problem hiding this comment.
can you add && npm run util:patch-es5-helpers to the end of these NPM scripts:
release:prepareutil:prep-nextutil:clean-tested-build
There was a problem hiding this comment.
I added it to build since all of the above reference it.
There was a problem hiding this comment.
Lol I literally looked for all the scripts that ran build to make that suggestion. Long day yesterday
jcfranco
deleted the
jcfranco/4481-patch-es5-helpers-to-work-around-tslib-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #4481
Summary
This patches the
__spreadArraytslib helper emitted frombuildEs5to handle spreading of strings within arrays.