Fix error in unit test from unsynched bulk (#1260)

Exawind · Apr 18, 2024 · 83c6597 · 83c6597
1 parent e320e98
commit 83c6597
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 6 deletions.
diff --git a/unit_tests/UnitTestUtils.C b/unit_tests/UnitTestUtils.C
@@ -157,10 +157,11 @@ create_one_element(
   }
   auto elem = stk::mesh::declare_element(
     bulk, block_1, bulk.parallel_rank() + 1, nodeIds);
-  stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
 
   bulk.modification_end();
 
+  stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
+
   auto surfaceSelector = stk::mesh::selectUnion(allSurfaces);
   stk::mesh::EntityVector all_faces;
   stk::mesh::get_selected_entities(

diff --git a/unit_tests/matrix_free/UnitTestConductionFields.C b/unit_tests/matrix_free/UnitTestConductionFields.C
@@ -91,10 +91,11 @@ protected:
     }
     auto elem = stk::mesh::declare_element(
       *bulk, block_1, bulk->parallel_rank() + 1, nodeIds);
-    stk::mesh::create_all_sides(*bulk, block_1, allSurfaces, false);
 
     bulk->modification_end();
 
+    stk::mesh::create_all_sides(*bulk, block_1, allSurfaces, false);
+
     auto surfaceSelector = stk::mesh::selectUnion(allSurfaces);
     stk::mesh::EntityVector all_faces;
     stk::mesh::get_selected_entities(

diff --git a/unit_tests/matrix_free/UnitTestStkSimdConnectivityMap.C b/unit_tests/matrix_free/UnitTestStkSimdConnectivityMap.C
@@ -87,10 +87,11 @@ protected:
     }
     auto elem = stk::mesh::declare_element(
       bulk, block_1, bulk.parallel_rank() + 1, nodeIds);
-    stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
 
     bulk.modification_end();
 
+    stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
+
     auto surfaceSelector = stk::mesh::selectUnion(allSurfaces);
     stk::mesh::EntityVector all_faces;
     stk::mesh::get_selected_entities(

diff --git a/unit_tests/matrix_free/UnitTestStkSimdFaceConnectivityMap.C b/unit_tests/matrix_free/UnitTestStkSimdFaceConnectivityMap.C
@@ -98,10 +98,11 @@ protected:
     }
     auto elem = stk::mesh::declare_element(
       bulk, block_1, bulk.parallel_rank() + 1, nodeIds);
-    stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
 
     bulk.modification_end();
 
+    stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
+
     auto surfaceSelector = stk::mesh::selectUnion(allSurfaces);
     stk::mesh::EntityVector all_faces;
     stk::mesh::get_selected_entities(

diff --git a/unit_tests/matrix_free/UnitTestStkSimdGatheredElementData.C b/unit_tests/matrix_free/UnitTestStkSimdGatheredElementData.C
@@ -105,10 +105,11 @@ protected:
     }
     auto elem = stk::mesh::declare_element(
       bulk, block_1, bulk.parallel_rank() + 1, nodeIds);
-    stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
 
     bulk.modification_end();
 
+    stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
+
     std::vector<std::vector<double>> nodeLocations = {
       {-1, -1, -1}, {+1, -1, -1}, {+1, +1, -1}, {-1, +1, -1},
       {-1, -1, +1}, {+1, -1, +1}, {+1, +1, +1}, {-1, +1, +1}};

diff --git a/unit_tests/matrix_free/UnitTestStkSimdNodeConnectivityMap.C b/unit_tests/matrix_free/UnitTestStkSimdNodeConnectivityMap.C
@@ -82,10 +82,11 @@ protected:
         stk::topology::NODE_RANK, id, stk::mesh::PartVector{});
     }
     auto elem = stk::mesh::declare_element(bulk, block_1, 1, nodeIds);
-    stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
 
     bulk.modification_end();
 
+    stk::mesh::create_all_sides(bulk, block_1, allSurfaces, false);
+
     auto surfaceSelector = stk::mesh::selectUnion(allSurfaces);
     stk::mesh::EntityVector all_faces;
     stk::mesh::get_selected_entities(