Revert "Converted to the new STK simple_fields workflow" #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8e8f4d5.
|
Hi @jrood-nrel, Could you share some more details about the seg-faults you were seeing? I'm unable to trigger any misbehavior with the intel-2021.1.2 compiler here at Sandia, with either the unit or regression tests. What compiler did you use, what machine was it on, and which test(s) were seg-faulting? Thanks! |
|
This was on Eagle. It's a case Ganesh is running. |
|
@jrood-nrel Thanks for the information! The stack trace was juuuust enough to figure it out. I messed up a Field name when configuring a Either way, I'll wait to reintroduce this simple_fields update until after @psakievich is finished with updating nalu-wind with his smart fields and field manager changes. This patch should be significantly smaller once that work is done. |
psakievich
added a commit
that referenced
this pull request
Apr 30, 2024
* Add Timers for FSI (#1221) * Add Timers for FSI * Style * Add FSI section to Input File docs. (#1220) * Add FSI section to Input File docs. * Updating the FSI docs to incorporate PR comments. * Relax projection for FSI mapping to account for curvature (#1223) * Relax projection for FSI mapping to account for curvature * Style * Format again * Add option to dump mesh on failed jacobian check (#1226) * Add option to dump mesh on failed jacobian check * Style * Cleaner, parallel consistent impl * Correctly set current_coordinates for restart (#1227) * Actually set current_coordinates for restart * Remove redundant call updating displacements * Revert "Remove redundant call updating displacements" This reverts commit dca015c. * Fix restart issue for FSI simulations (#1228) --------- Co-authored-by: Ganesh Vijayakumar <[email protected]> * Update FieldRegistry.h (#1229) missing std::. * FSI: Set ramping defaults to false (#1231) * FSI: Set ramping defaults to false Since we are moving to split meshes as the current strategy setting ramping defaults to `False`. I have been investigating why the temporal ramping is causing simulations to fail since the bug fixes regarding hub motion, and I can't find any issues with it at the moment. So it seems best to keep that turned off as well. * Update real defaults * add a string-function temperature IC/dirichlet bc (#1198) * add a string-function temperature IC/dirichlet bc * undo stk deprecation fixes --------- Co-authored-by: psakievich <[email protected]> * Converted to the new STK simple_fields workflow (#1233) STK is migrating to a new strategy for registering and managing Fields, where sizing information is purely specified at run-time instead of the previous technique of specifying it in a confusing blend of both compile-time and run-time information. The compile-time specification was just a suggestion, as it could be overridden (possibly inconsistently) at run-time to support variable-length Fields. This made it unclear what the true size of a Field was and where it should be specified. As an example, registering a vector field on the entire mesh previously looked like this: using VectorField = stk::mesh::Field<double, stk::mesh::Cartesian3d>; VectorField & field = meta.declare_field<VectorField>(stk::topology::NODE_RANK, "velocity"); stk::mesh::put_field_on_mesh(field, meta.universal_part(), 3, nullptr); and now, it looks like this: using VectorField = stk::mesh::Field<double>; VectorField & field = meta.declare_field<double>(stk::topology::NODE_RANK, "velocity"); stk::mesh::put_field_on_mesh(field, meta.universal_part(), 3, nullptr); stk::io::set_field_output_type(field, stk::io::FieldOutputType::VECTOR_3D); // Optional The only template parameter for a Field is now the datatype parameter. Sizing information now exclusively comes from put_field_on_mesh() calls. The optional set_field_output_type() function call registers with the IO sub-system how a multi-component Field should be subscripted in Exodus files. If this call is left off, you will get the default [_1, _2, _3] subscripting. With the above call, you will instead get [_x, _y, _z] subscripting. The MetaData::use_simple_fields() flag is set everywhere possible in the code to prevent accidental regressions before the old behavior is formally deprecated and removed. This will yield a run-time error if the old-style extra template parameters are used anywhere. These calls to use_simple_fields() can be removed in the future once the STK Mesh back-end has removed support for the old behavior. This wasn't a completely straightforward conversion due to nalu-wind making heavy use of various algorithm selections based on the templated Field type. The ScalarFieldType, VectorFieldType, TensorFieldType, and GenericFieldType types are now all identical, so different techniques had to be used to switch behaviors. * Fixes errors in ghosting update for some overset mesh problems. (#1214) Instead of trying to modify the ghosting for overset problems with relative motion, we now just rebuild the ghosting from scratch. This appears to fix errors such as those reported in #936 Co-authored-by: dcdemen <[email protected]> Co-authored-by: psakievich <[email protected]> * Revert "Converted to the new STK simple_fields workflow (#1233)" (#1234) This reverts commit 8e8f4d5. * Fixed the iblank inconsistency at shared nodes. The iblank field is returned to Tioga after the stk::mesh::copy_owned_to_shared operation, prior to field interpolation (#1238) * Multiphase milestone (#1222) * Divide through by density to get velocity form * Fix VOF velocity flux to finalize * Fix missing pressure gradient density norm and sharpen interfaces more * Add diffusion term to VOF * center droplet and provide velocity * first version of sloshing tank * sloshing tank case, can change parameters * Mass-momentum consistency with initial vel scale and diffusion values * Remove unused forced mass flux from pressure equation * clean-up and safe settings for VOF advection * Density face definition for minimized buoyancy noise * rho_ref == initial density * Change initial density to a specified function and introduce wall bcs for VOF * sloshing tank pressure profile * user function for generic flat water level in z * Cleaning * Balanced Buoyancy Forcing * Complete milestone implementation * Full implementation with fixed testing * Fix allocation of fields * Formatting * Documentation of VOF advection scheme --------- Co-authored-by: whorne <[email protected]> Co-authored-by: Michael Kuhn <[email protected]> * Rebase and pressure gradient improvements for VOF * Fixed interface width work * Allow slip of VOF at wall bcs --------- Co-authored-by: psakievich <[email protected]> Co-authored-by: neilmatula <[email protected]> Co-authored-by: Ganesh Vijayakumar <[email protected]> Co-authored-by: 四月是你的谎言 <[email protected]> Co-authored-by: rcknaus <[email protected]> Co-authored-by: djglaze <[email protected]> Co-authored-by: ddement <[email protected]> Co-authored-by: dcdemen <[email protected]> Co-authored-by: Jon Rood <[email protected]> Co-authored-by: itopcuoglu <[email protected]> Co-authored-by: whorne <[email protected]> Co-authored-by: Michael Kuhn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1233
This PR was causing Nalu-Wind to segfault when using the Intel compiler.