Updates to use latest Trilinos develop branch #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanw0
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Looks good, a bunch of search/replace and add prefix...
The other API changes you encountered went through a deprecation cycle where they would have been a warning for at least 6 weeks before they were actually changed in a way that causes an error. Sometimes we debate whether we should lengthen the deprecation window to be more gentle on users that don't update as often...
psakievich
approved these changes
Apr 12, 2024
|
Just a reminder that this will break all of our default builds so we will need to add versions and update dependencies in spack right away. |
|
Yeah I will get other stuff in place before merging this. I'm mostly curious if it will help me with the segfaults on Aurora. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.