Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ktor version 3 #2045

Closed

Conversation

ronjunevaldoz
Copy link

📝 Description

Upgrade ktor to version 3.x.x

🔗 Related Issues

#2037

@ronjunevaldoz
Copy link
Author

ronjunevaldoz commented Oct 17, 2024

found some error that requires Kotlin version to be at-least 2.0.0-RC1.

Since there was an existing TODO, I let someone upgrade it first then. I'll bump to ktor stable versions instead (v3.0.0)

TODO kotlin 1.9 upgrade: fix GraphQLTestUtils and GenerateKotlinxClientIT
Your current Kotlin version is 1.9.24, while kotlinx.serialization core runtime 1.7.2 requires at least Kotlin 2.0.0-RC1. Please update your Kotlin compiler and IDE plugin.

@daniel-humla
Copy link
Contributor

@ronjunevaldoz Kotlin is now bumped to version 2 so this could be picked up again

@ronjunevaldoz
Copy link
Author

@ronjunevaldoz Kotlin is now bumped to version 2 so this could be picked up again

checking on it

@ronjunevaldoz ronjunevaldoz marked this pull request as ready for review November 17, 2024 02:08
@samuelAndalon
Copy link
Contributor

closing in favor of the other ktor update PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants