Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write and read mesh using ADIOS2 #3291
base: main
Are you sure you want to change the base?
Write and read mesh using ADIOS2 #3291
Changes from 25 commits
8c2756f
42487b3
bf40802
e66b319
df6ed6d
bf78637
339c1f0
6ebac6e
5a4d190
e644b5e
1d97e78
1b2a243
f2d3115
5dd47c6
0e1b770
b8ebd93
76f018f
7ae238a
eb0e813
d3a965b
729846b
6025802
b2f4bd0
011027b
d7e8e3a
ca94e17
55b9288
241fbef
43f6481
4d71e4c
659281a
38bb3d5
f8d5701
0940f59
2a4a986
cbc6fb2
d82a412
5f4a50d
d537461
4178385
6d34167
3f6ce60
8162339
b93cc2e
73a2643
c81221d
20708f5
5f7d505
55b266c
1c548db
ff0fb62
a3fe473
dd524c7
636f742
77f059f
64480e2
61a8288
2611b1b
e988a0a
2cfebf2
2688e51
fb39916
8bec1a1
24bab34
a0543eb
80265ae
9583a3b
473bba4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implicit write seems odd; no default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default
mode
isadios2::Mode::Write
For a reader, we need to specify
adios2::Mode::Read
explicitly.Did you mean this or did I not understand your comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a clear idea of how this will extend to the mixed topology mesh case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisrichardson can comment on the data structure of how mixed topology is implemented.
Instead of constant
num_dofs_per_cell
and hence a fixed array of shape(num_cells, num_dofs_per_cell)
, we can use AdjacencyList.Similar to the example from meshtags, offsets and global size can be computed as
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use types in variable names, clear from right hand side.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meaning use
array
,offsets
instead oftopology_array
,topology_offsets
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible with standard library iterators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about use of shared pointer here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need to discuss checkpointing terminology. Native IO could be a better description.