[1.18] Fix block duplication due to separate Fabric BlockPlace and BlockRightClick events #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and private setting check
|
Hmm, if possible, I'd obviously like to see this properly resolved on the Architectury / Fabric side so we don't have to use more platform stuff than strictly necessary |
|
@MaxNeedsSnacks can you confirm if you plan on fixing this issue in Arch any time soon or should I pull this in until it's resolved your end? |
|
@zach2039 if you're still interested in getting this merged, could you please rebase it on the latest |
|
Given the lack of response, I'm inclined to extract the code from this and manually patch it into Chunks. Needs doing since it does lead to a dupe on Fabric at the moment. If/when Architectury gets updated to better separate the concept of use and place, we can switch to that. |
desht
added a commit
that referenced
this pull request
Feb 10, 2023
Manual adaptation and pull of #213 Merge the block interaction and block edit properties on Fabric, since we cannot reliably distinguish right-clicking a block to use it versus right-clicking a block to place it. Means reduced functionality on Fabric vs. Forge, but still better than allowing dupes to occur. Also added a little code to re-sync client's held item from the server whenever a place or use event is cancelled. FTBTeam/FTB-Mods-Issues#673 FTBTeam/FTB-Mods-Issues#315
desht
added a commit
that referenced
this pull request
Feb 21, 2023
Manual adaptation and pull of #213 Merge the block interaction and block edit properties on Fabric, since we cannot reliably distinguish right-clicking a block to use it versus right-clicking a block to place it. Means reduced functionality on Fabric vs. Forge, but still better than allowing dupes to occur. Also added a little code to re-sync client's held item from the server whenever a place or use event is cancelled. FTBTeam/FTB-Mods-Issues#673 FTBTeam/FTB-Mods-Issues#315
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FTBTeam/FTB-Mods-Issues#315.
Key changes:
Tested in fabric dev environment on with server and two clients.