Fix FTB-Mods-Issues#81, #41, #28

[BobVarioa]

Fixes FTBTeam/FTB-Mods-Issues#81, FTBTeam/FTB-Mods-Issues#41, FTBTeam/FTB-Mods-Issues#28, and FTBTeam/FTB-Mods-Issues#30.
Currently not complete.

Rewards

Repeat (done), with limited number of repeats (done, FTBTeam/FTB-Mods-Issues#30)

Rewards that reset that quest they belong to's tasks and rewards.

Optional (done)

A property that can set on rewards that will let them not be collected by the "Claim all rewards" button.

Global

A property that can be set on rewards that lets them only be collected once, for all teams / players.

Tasks (done)

Scoreboard (done)

A task that gets completed based on the value of a particular scoreboard, on the player that completed the quest or a specific one.

Exclusive (done)

A task that gets marked as incomplete once it is normal condition is incomplete, even if the task has been completed previously.

Editing

Clear rewards from multiple (done)

Clears all rewards from selected quests. As simple as it sounds.

Copy and paste

Self explanatory. Rewards and tasks can be copied individually as well.

Moving edit to the top of the list (done, FTBTeam/FTB-Mods-Issues#41)

Title.

Misc

Invisible (done), Invisible until X tasks are completed (done)

Quests that can be completed even if they are not visible.

Split Choice

Quests that can have multiple sets of rewards and tasks that are mutually exclusive. Though the person that requested this did not ask for this feature, I might also add chained quests using this system, similar to a feature in BetterQuesting.

Rewards as emergency items (FTBTeam/FTB-Mods-Issues#28)

Rewards can that be claimed from the emergency items feature.

Defaults for the quest's screen size (done)

Title.

[MichaelHillcox]

I full support making changes, please make sure you are clear with what you have implemented, how it modifies the exisitng functionality. Also, supply images as well as all of this will ease the PR process on our end <3

[BobVarioa]

Alright, thanks!

[Darkmega18]

A condition that gets marked as incomplete once it is normal condition would be met. While I feel this doesn't make much sense, I will include it per this person's request.

Ah. I see where the confusion is. Basically that suggestion was meaning:

If task is completed it's completed. BUT. if the task suddenly detects that it's no longer valid, like say, a scoreboard is no longer the correct value or you lose a certain item/no longer have it in your possession, the quest resets it's own task to incomplete again, until the item or scoreboard state is reacquired and it is once again fulfilled.
obviously it's not much sense for something you trade in as once it's traded in it's traded in. But for quests where you simply need to possess the item or potion or something this is where it can come in.

basically, for an example I want to use this in:
The character in my quests normally wears an amulet (the enigmatic amulet from enigmatic legacy) that lets them communicate with someone and the quests that complete will often have little comments and information tidbits from the character.
But in the case of the player dieing and now the amulet becomes their death pile protection capsule as per that amulet's function from the mod, the character can't get these communications from the character on the otherside anymore until they retrieve the amulet again. and those quests won't complete, provided they haven't already been completed previously.

[BobVarioa]

This makes much, much, more sense. Thanks for the clarification!

[Darkmega18]

This makes much, much, more sense. Thanks for the clarification!

welcome. and sorry. sometimes I get carried away and my writing gets a little confusing or fluffy. :V glad I saw your write up attached to the issue and could clarify before it became something odd.

[CLAassistant]

All committers have signed the CLA.

[MaxNeedsSnacks]

o/ Mind if I asked about the status of this PR? Currently doing some housekeeping on the FTB mod repos and I was wondering whether you'd consider this to be ready for review now or whether it still needs some additional work ^^

[Darkmega18]

nani? something got deleted?

[desht]

Nope, we were rearranging some branch names for the project and github auto-closed it. But this is a good reminder for me to go over this and see what's still needed from it.

[Darkmega18]

Ah nice, I see. Gonna probably need to be using the mod again soon, cause more modpack making (when will I ever learn?) so it's good this is being worked through so I can maybe enact some uses for them. :D

[Explode007]

I have a suggestion related to default options.
Some of the configurations/options are kinda hit or miss.

For example, I can't make the default behavior in a chapter be to consume Items, but I can do it Globally. Therefore having to make each quest say 'consumes items' or copy pasting a base quest to subside those things is kinda annoying (I mostly handle it by isolating the chapter in SNBT and then searching for 'consume_items' and setting that to true for anyone struggling as well).

Another inconsistency is why can I right click a specific task in a quest and select that as the default icon for the quest but not do the same on the rewards? This one is actually really annoying because I end up having to do the same thing twice instead of the quest just taking up the reward side.

Another one is Multi-Select + Right-Click options. I would like to see an option to change all common settings for all those quests, and that by itself should alleviate a lot of the aforementioned things as well, because it allows mass editing. For example, What if I want to change the shape of like 30 quests to rounded square but keep the rest as a hexagon? Or what if I want all those quests to consume items?

Things like this that help mass editing would be a great help