fix issue with incorrect matches for some surrogate chars #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjfanning
commented
Nov 14, 2024
| private boolean _isSurrogateChar(int ch) { | ||
| return (ch & 0xD800) == 0xD800; | ||
| private static boolean _isStartOfSurrogatePair(final int ch) { | ||
| return (ch & 0xF800) == 0xD800; |
There was a problem hiding this comment.
I made this change based on comments in #1359 but would like to have it reviewed
There was a problem hiding this comment.
Updated my comment: I think mask actually needs to be 0xFC00 for First surrogate (i.e. not match Second part of surrogate pair). Will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1359