-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serialization of object members for csv. #97
base: 2.9
Are you sure you want to change the base?
Conversation
ptahchiev
commented
Jul 29, 2018
- Keep track of object nesting, similar to jackson-dataformat-properties
- Keep track of object nesting, similar to jackson-dataformat-properties
Is there any problem with this PR? |
@nstdio At this point there is one practical problem (aside from merge conflict): being new feature, this needs to be rebased against 2.11. But I do not remember any specific problem against the concept: my main question would be that since I will add this PR to my todo list to have another look as it seems valuable, in helping deal with nested values in CSV. |
@cowtowncoder yes, exactly. Also, users not always control/own models and adding a |
Ok. So, finally getting to this one.... and realizing there are actually couple of problems to resolve. A practical one is that unfortunately patch has re-styled code, making diff unnecessarily large, and adding work when I have to undo many (not all, just many) changes. But a bigger one is this: I don't want additional processing overhead for common case of no nesting. So will need to figure out how to avoid automatic prepending and only change name in cases where it is needed for nesting. So this may take a bit longer yet. |
Another thing I am not sure about is addition of path separator per column; not sure how that would work compared to per document (one for whole |
I'd love to see this feature goes in the code. since CVS is much more compact than JSON in dealing with large data set. In my case I have to convert between json and CSV without any predefined POJO involved. This is much needed and I don't want to create a fork out of the official Jackson |
Note: would like to consider this, but would need rework to merge against 2.13 (next applicable minor version). |
Ok so due to unfortunate reformatting of this patch (probably accidentally done by some reformatter?), it's bit difficult to follow, but now realized that this would only support serialization, not deserialization. |