Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(routes)!: rename camelCase query string params to snake_case #1964

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

Fdawgs
Copy link
Owner

@Fdawgs Fdawgs commented Nov 25, 2024

BREAKING CHANGE: all camelCase query string params renamed to snake_case, i.e. backgroundColor is now background_color

Checklist

BREAKING CHANGE: `removeAlt` query string param renamed to `remove_alt`
@coveralls
Copy link

coveralls commented Nov 25, 2024

Pull Request Test Coverage Report for Build 12011725800

Details

  • 18 of 18 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12009969638: 0.0%
Covered Lines: 674
Relevant Lines: 674

💛 - Coveralls

BREAKING CHANGE: `backgroundColor` query string param renamed to `background_color`
BREAKING CHANGE: `extractHidden` query string param renamed to `extract_hidden`
BREAKING CHANGE: all camelCase query string params renamed to snake_case
@Fdawgs Fdawgs linked an issue Nov 25, 2024 that may be closed by this pull request
@Fdawgs Fdawgs requested a review from Copilot November 25, 2024 14:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 24 out of 24 changed files in this pull request and generated no suggestions.

@Fdawgs Fdawgs merged commit 46cedc7 into main Nov 25, 2024
17 checks passed
@Fdawgs Fdawgs deleted the refactor/qs-params branch November 25, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename all query string params that use camelCase
2 participants