Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix staticcheck warnings #589

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix staticcheck warnings #589

wants to merge 1 commit into from

Conversation

AlexanderYastrebov
Copy link

@AlexanderYastrebov AlexanderYastrebov commented Sep 15, 2024 •
edited
Loading 

$ staticcheck ./... | fmt -w 80 -s
internal/format/format.go:204:17: error strings should not end with punctuation
or newlines (ST1005)
internal/stream/stream.go:15:2: "golang.org/x/crypto/poly1305" is
deprecated: Poly1305 as implemented by this package is a cryptographic
building block that is not safe for general purpose use. For
encryption, use the full ChaCha20-Poly1305 construction implemented by
golang.org/x/crypto/chacha20poly1305. For authentication, use a general
purpose MAC such as HMAC implemented by crypto/hmac.  (SA1019)
plugin/client.go:385:2: field stderr is unused (U1000)
$ gotip vet ./cmd/...
cmd/age-keygen/keygen.go:161:13: non-constant format string in call to log.Printf

@AlexanderYastrebov
Fix staticcheck warnings
4ec1617 
$ staticcheck ./... | fmt -w 80 -s
internal/format/format.go:204:17: error strings should not end with punctuation
or newlines (ST1005)
internal/stream/stream.go:15:2: "golang.org/x/crypto/poly1305" is
deprecated: Poly1305 as implemented by this package is a cryptographic
building block that is not safe for general purpose use. For
encryption, use the full ChaCha20-Poly1305 construction implemented by
golang.org/x/crypto/chacha20poly1305. For authentication, use a general
purpose MAC such as HMAC implemented by crypto/hmac.  (SA1019)
plugin/client.go:385:2: field stderr is unused (U1000)

$ gotip vet ./cmd/...
cmd/age-keygen/keygen.go:161:13: non-constant format string in call to log.Printf
This was referenced Oct 18, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matdibu matdibu matdibu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderYastrebov @matdibu