refactor: use map instead of a for loop for runPackageCommand calls

Financial-Times · Jul 25, 2024 · ff2e589 · ff2e589
1 parent 63dc37f
commit ff2e589
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/plugins/monorepo/src/tasks/workspace-command.ts b/plugins/monorepo/src/tasks/workspace-command.ts
@@ -19,13 +19,10 @@ export default class WorkspaceCommand extends Task {
 
     const workspaces = await mapWorkspaces({ cwd, pkg })
 
-    const packagePromises: Array<Promise<void>> = []
-
-    for (const [id, packagePath] of workspaces) {
-      packagePromises.push(this.runPackageCommand(id, packagePath, command, files))
-    }
+    const results = await Promise.allSettled(
+      Array.from(workspaces, ([id, packagePath]) => this.runPackageCommand(id, packagePath, command, files))
+    )
 
-    const results = await Promise.allSettled(packagePromises)
     const erroredCommands = results.filter(
       (result): result is PromiseRejectedResult => result.status === 'rejected'
     )