Allow CircleCI workflow job options to be overridden #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that one plugin can override the options of a parent plugin. In the future it might be worth validating that the final merged hook options include all the required options but that will be slightly more complicated and I don't think it's necessary right now.
apaleslimghost
approved these changes
Nov 27, 2024
ivomurrell
force-pushed
the
circleci-workflow-jobs
branch
from
fac03cd to
e33e579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously jobs in CircleCI workflows (i.e., where you define which jobs a workflow runs and which custom parameters to use) could not be overridden by other plugins as they were a deeper part of the hook options that the merging logic didn't reason about.
This allows us to move the Cloudsmith changes in #710 into a separate plugin.
Checklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too