-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more comprehensive React docs #1141
Conversation
WalkthroughThe updates enhance the integration of Flatfile's import capabilities into React applications by introducing a suite of new React components and hooks. These additions provide developers with a comprehensive toolkit for configuring and managing data import processes efficiently within React. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedLanguageTool (12)
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Out of diff range and nitpick comments (1)
apps/embedding/react/legacy.mdx (1)
Line range hint
42-42
: Improve the clarity of the sentence by starting with a verb.- Setup your app to look something like this: + Set up your app to look something like this:
One comment - the link on apps/embedding/react/guide for "start from scratch" will need to be updated. |
96d26b6
to
538baf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 8
Out of diff range and nitpick comments (4)
apps/embedding/react/guide.mdx (1)
Line range hint
15-15
: Consider rephrasing the guide's introduction to make it more engaging and concise.- First, decide if you want to start from scratch or make changes to an existing project. Most developers find it easier to clone and start from a working example. + First, choose whether to start from scratch or modify an existing project. Cloning a working example is often easier.apps/embedding/react/legacy.mdx (3)
Line range hint
42-42
: Consider rephrasing the introduction to the file structure section for better clarity and grammatical correctness.- Setup your app to look something like this: + Set up your app to look something like this:
Line range hint
279-279
: Consider rephrasing to add variety to the writing and avoid repetition.- Also, add the content here to your `index.tsx`, `tsconfig.json`, `manifest.json`, and `config-overries.js`. + Additionally, include the content in your `index.tsx`, `tsconfig.json`, `manifest.json`, and `config-overries.js`.
Line range hint
444-444
: Add a comma before 'or' to improve the readability of the sentence.- You can stop here or you can [view our full reference](../reference/common) to see all the ways you can customize your importer. + You can stop here, or you can [view our full reference](../reference/common) to see all the ways you can customize your importer.
60e17fb
to
c16bab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 10
Out of diff range and nitpick comments (4)
apps/embedding/react/legacy.mdx (4)
Line range hint
29-29
: Consider adding the article "the" for better clarity.- Follow prompts from the `init` command. + Follow the prompts from the `init` command.
Line range hint
42-42
: Consider rephrasing the sentence for better clarity.- Setup your app to look something like this: + Set up your app to look something like this:
Line range hint
279-279
: Consider rephrasing to add variety to your writing.- Also, add the content here to your `index.tsx`, `tsconfig.json`, `manifest.json`, and `config-overries.js`. + Additionally, include the content here in your `index.tsx`, `tsconfig.json`, `manifest.json`, and `config-overries.js`.
Line range hint
444-444
: Use a comma before "or" for better clarity.- You can stop here or you can [view our full reference](../reference/common) to see all the ways you can customize your importer. + You can stop here, or you can [view our full reference](../reference/common) to see all the ways you can customize your importer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
|
||
### Workbook | ||
|
||
Configures all Workbook Creation request data and an new onRecordHooks helper function |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the article usage before "new".
- Configures all Workbook Creation request data and an new onRecordHooks helper function
+ Configures all Workbook Creation request data and a new onRecordHooks helper function
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Configures all Workbook Creation request data and an new onRecordHooks helper function | |
Configures all Workbook Creation request data and a new onRecordHooks helper function |
- `submitSettings`: Customizes the behavior of the data submission process. | ||
|
||
|
||
The Sheet option is similar to the [Simplified SDK Approach](apps/embedding/reference/simple).. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the extra period.
- The Sheet option is similar to the [Simplified SDK Approach](apps/embedding/reference/simple)..
+ The Sheet option is similar to the [Simplified SDK Approach](apps/embedding/reference/simple).
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
The Sheet option is similar to the [Simplified SDK Approach](apps/embedding/reference/simple).
- `config`: Sets up the configuration for a new space, including theming and metadata. | ||
- `id`: An optional prop that, when provided, indicates the specific existing space to be reused instead of creating a new one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure consistent punctuation in lists.
- - `config`: Sets up the configuration for a new space, including theming and metadata.
- - `id`: An optional prop that, when provided, indicates the specific existing space to be reused instead of creating a new one.
+ - `config`: Sets up the configuration for a new space, including theming and metadata;
+ - `id`: An optional prop that, when provided, indicates the specific existing space to be reused instead of creating a new one;
- - `config`: Defines the structure and settings of the data to be imported.
- - `onSubmit`: A callback function that is triggered upon successful data submission.
- - `onRecordHook`: A function that allows for custom record manipulation during the import process.
- - `submitSettings`: Customizes the behavior of the data submission process.
+ - `config`: Defines the structure and settings of the data to be imported;
+ - `onSubmit`: A callback function that is triggered upon successful data submission;
+ - `onRecordHook`: A function that allows for custom record manipulation during the import process;
+ - `submitSettings`: Customizes the behavior of the data submission process;
- - `openPortal()`: Opens the iFrame. This will create the underlying Space, Workbook and configure if necessary or open the Space provided.
- - `closePortal()`: Closes the iFrame.
- - `open`: current open status
- - `listener`: Current listener
- - `setListener()`: manually sets the listener
+ - `openPortal()`: Opens the iFrame. This will create the underlying Space, Workbook and configure if necessary or open the Space provided;
+ - `closePortal()`: Closes the iFrame;
+ - `open`: current open status;
+ - `listener`: Current listener;
+ - `setListener()`: manually sets the listener;
Also applies to: 104-107, 141-143
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
- `config`: Sets up the configuration for a new space, including theming and metadata. | |
- `id`: An optional prop that, when provided, indicates the specific existing space to be reused instead of creating a new one. | |
- `config`: Sets up the configuration for a new space, including theming and metadata; | |
- `id`: An optional prop that, when provided, indicates the specific existing space to be reused instead of creating a new one; |
No description provided.