feat: fix build bug, remove environmentId requirement and stop deleti…

…ng spaces
FlatFilers · Apr 11, 2024 · 6d56962 · 6d56962
1 parent 7e5fe8a
commit 6d56962
Show file tree

Hide file tree

Showing 5 changed files with 139 additions and 15 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/angular/projects/spaces/src/lib/space/space-frame/spaceFrame.component.ts b/packages/angular/projects/spaces/src/lib/space/space-frame/spaceFrame.component.ts
@@ -57,7 +57,7 @@ export class SpaceFrame implements OnInit {
     const dispatchEvent = (event: any) => {
       if (!event) return
 
-      const eventPayload = event.src ? event.src : event
+      const eventPayload = event.src || event
       const eventInstance = new FlatfileEvent(eventPayload, accessToken, apiUrl)
 
       return listenerInstance?.dispatchEvent(eventInstance)

diff --git a/packages/angular/projects/spaces/src/utils/createSimpleListener.ts b/packages/angular/projects/spaces/src/utils/createSimpleListener.ts
@@ -1,5 +1,6 @@
-import api from '@flatfile/api'
+import { FlatfileClient } from '@flatfile/api'
 import {
+  DefaultSubmitSettings,
   JobHandler,
   SheetHandler,
   SimpleOnboarding,
@@ -9,27 +10,33 @@ import { FlatfileEvent, FlatfileListener } from '@flatfile/listener'
 import { recordHook } from '@flatfile/plugin-record-hook'
 
 interface SimpleListenerType
-  extends Pick<SimpleOnboarding, 'onRecordHook' | 'onSubmit'> {
+  extends Pick<
+    SimpleOnboarding,
+    'onRecordHook' | 'onSubmit' | 'submitSettings'
+  > {
   slug: string
 }
 
+const api = new FlatfileClient()
+
 const createSimpleListener = ({
   onRecordHook,
   onSubmit,
   slug,
+  submitSettings,
 }: SimpleListenerType) =>
   FlatfileListener.create((client: FlatfileListener) => {
     if (onRecordHook) {
       client.use(
         recordHook(
           slug,
           async (record: FlatfileRecord, event?: FlatfileEvent) =>
-            // @ts-ignore - something weird with the `data` prop and the types upstream in the packages being declared in different places, but overall this is fine
             onRecordHook(record, event)
         )
       )
     }
     if (onSubmit) {
+      const onSubmitSettings = { ...DefaultSubmitSettings, ...submitSettings }
       client.filter(
         { job: 'workbook:simpleSubmitAction' },
         (configure: FlatfileListener) => {
@@ -46,21 +53,22 @@ const createSimpleListener = ({
               // this assumes we are only allowing 1 sheet here (which we've talked about doing initially)
               const sheet = new SheetHandler(workbookSheets[0].id)
 
-              await onSubmit({ job, sheet })
+              if (onSubmit) {
+                await onSubmit({ job, sheet, event })
+              }
 
               await api.jobs.complete(jobId, {
                 outcome: {
                   message: 'complete',
                 },
               })
-              await api.spaces.delete(spaceId)
+              if (onSubmitSettings.deleteSpaceAfterSubmit) {
+                await api.spaces.archiveSpace(spaceId)
+              }
             } catch (error: any) {
               if (jobId) {
                 await api.jobs.cancel(jobId)
               }
-              if (spaceId) {
-                await api.spaces.delete(spaceId)
-              }
               console.error('Error:', error.stack)
             }
           })

diff --git a/packages/angular/projects/spaces/src/utils/useInitializeSpace.ts b/packages/angular/projects/spaces/src/utils/useInitializeSpace.ts
@@ -38,10 +38,6 @@ const useInitializeSpace = (
         throw new Error('Missing required publishable key')
       }
 
-      if (!environmentId) {
-        throw new Error('Missing required environment id')
-      }
-
       const limitedAccessApi = authenticate(publishableKey, apiUrl)
       const spaceRequestBody = {
         name,

diff --git a/packages/angular/src/app/app.component.ts b/packages/angular/src/app/app.component.ts
@@ -24,8 +24,8 @@ export class AppComponent {
 
   spaceProps: ISpace = {
     name: 'Trste!',
-    environmentId: 'us_env_1234',
-    publishableKey: 'sk_1234',
+    environmentId: 'us_env_ZvaDGP3B',
+    publishableKey: 'pk_0d40167fccfc47e9a4ec0223e9787e63',
     workbook,
     listener,
     userInfo: {