fix handling of empty list tags #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty list tags save the child type as "0" which is a tag-type that `class_from_type` cannot map. If the list is empty, the child-tag-type doesn't matter anyhow, so we can exit early without handling anything children related. This issue appeared when trying to use `CraftBook::NBT::Tag.from_hash tag.to_h` to deep-clone an existing NBT-tag after reading a schematic file created by the Minecraft mod Structurize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty list tags save the child type as "0" which is a tag-type that
class_from_typecannot map.If the list is empty, the child-tag-type doesn't matter anyhow, so we can exit early without handling anything children related.
This issue appeared when trying to use
CraftBook::NBT::Tag.from_hash tag.to_hto deep-clone an existing NBT-tag after reading a schematic file created by the Minecraft mod Structurize