Add new Ctrl+F shortcut #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kommunarr
force-pushed
the
feat/add-ctrl-f
branch
2 times, most recently
from
54987a5
to
c4f1703
Compare
kommunarr
force-pushed
the
feat/add-ctrl-f
branch
from
c4f1703
to
6da5ae9
Compare
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE,
absidue,
ChunkyProgrammer and
MarmadileManteater
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 1, 2024
ChunkyProgrammer
approved these changes
May 1, 2024
|
See comment:
|
PikachuEXE
reviewed
May 2, 2024
Comment on lines
-64
to
+69
| If you'd like to see even more keyboard shortcuts, consider creating a [feature request](https://github.com/FreeTubeApp/FreeTube/issues/new?assignees=&labels=enhancement&template=feature_request.yaml&title=%5BFeature+Request%5D%3A+). | ||
| If you'd like to see even more keyboard shortcuts, consider creating a [feature request](https://github.com/FreeTubeApp/FreeTube/issues/new?assignees=&labels=enhancement&template=feature_request.yaml&title=%5BFeature+Request%5D%3A+). |
There was a problem hiding this comment.
Is there a change here? I can't spot it
Also waiting on release to merge (ping me though coz I definitely will forget
There was a problem hiding this comment.
It's a white space change, i think line ending might have changed?
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
PikachuEXE and
ChunkyProgrammer
PikachuEXE
approved these changes
Jun 20, 2024
absidue
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to FreeTubeApp/FreeTube#4970. Would like to wait until just before the release to merge this. Or we can add a
developmentbranch for this repo.