Fix player full screen causing the app to start in full screen #5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
There was a problem hiding this comment.
Full screen doesn't persist if player is full-screened
- Open a video
- Full screen the player, either through the button or the F hotkey
- Close the app e.g. Ctrl+Q or Alt+F4
- Open the app again and make sure it launches with normal window dimensions
Works!
Full screen persists if you full screen the window (regression test)
- Full screen the window e.g. F11
- Close the app e.g. Ctrl+Q or Alt+F4
- Open the app again and make sure it launches in full screen.
Works!
Full screen persists if you full screen the window and if player is fullscreened
- Full screen the window e.g. F11
- Full screen the player, either through the button or the F hotkey
- Close the app e.g. Ctrl+Q or Alt+F4
- Open the app again and make sure it launches in full screen.
App unfortunately doesn't launch in fullscreen, tested on win10
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
This comment was marked as outdated.
This comment was marked as outdated.
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This PR is stale because it has been open 28 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
|
doesnt this also address #3220? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix player full screen causing the app to start in full screen
Pull Request Type
Related issue
Description
This is an alternative to #4649 that should hopefully work more consistently (the creator of that pull request is aware that I am making this one).
When the app is closed while in full screen regardless of whether only the player or the entire window was full-screened, we save the full screen state and restore it at start up. For people that full-screened the app that is great, but for people that full-screened the player it's less desirable to have the entire app start in full screen.
Testing
Full screen doesn't persist if player is full-screened
Full screen persists if you full screen the window (regression test)
Desktop