Support saving screenshots as WebP files #6263
Open
+6
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 2, 2024
PikachuEXE
reviewed
Dec 3, 2024
| @@ -1488,7 +1488,7 @@ export default defineComponent({ | |||
|
|
|||
| const format = screenshotFormat.value | |||
| const mimeType = `image/${format === 'jpg' ? 'jpeg' : format}` | |||
| const imageQuality = format === 'jpg' ? screenshotQuality.value / 100 : 1 | |||
| const imageQuality = format !== 'png' ? screenshotQuality.value / 100 : 1 | |||
There was a problem hiding this comment.
Just throw the value into it without checking format?
For png it doesn't change anything
There was a problem hiding this comment.
So replace the ternary with a code comment? We need something there.
There was a problem hiding this comment.
Just throw screenshotQuality.value / 100 in and maybe with a comment about png format doesn't care about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support saving screenshots as WebP files
Pull Request Type
Related issue
Description
This pull request adds support for saving screenshots as WebP files. The other two requested formats are not possible as explained in my comment on that feature request (TL;DR Chromium doesn't support encoding to AVIF and doesn't support JPEG XL at all, not even displaying them), so I feel like it is appropriate to close it even if we only implement support for saving as WebP files.
Testing
Take some screenshots with the WebP format selected, you can also experiment with the quality setting to see how it affects the file size and visual quality.
Desktop