Take the send history into account in the transportState filter #90
Conversation
flkasper
force-pushed
the
feature/filter-last-history-mail-transport-state
branch
from
a1ead91
to
6961ea8
Compare
| @@ -47,6 +56,7 @@ protected function defineFields(): FieldCollection | |||
| (new LongTextField('eml', 'eml'))->addFlags(new AllowHtml()), | |||
| (new StringField('eml_path', 'emlPath', 2048)), | |||
| (new StringField('transport_state', 'transportState'))->addFlags(new Required()), | |||
| new BoolField('history_last_mail', 'historyLastMail'), | |||
There was a problem hiding this comment.
I don't really like the idea of adding a separate column for historyLastMail. Why not just do a groupBy on sourceMailId/parentId?
There was a problem hiding this comment.
@schneider-felix
As discussed on Saturday, I tried a GroupBy via a historyGroupId column.
This column can be realized as a virtual column that reflects the value of parent_id/id.
However, this does not work as expected.
When I use criteria.addGrouping('historyGroupId') in the admin, the result is not correct.
The last element is not returned as expected.
Did I use the addGrouping incorrectly or does it not work like a GroupBy in SQL?
The customized code can be found at: Link to Branch
If we cannot fix the grouping, we will have to stick with the less attractive solution with historyLastMail.
There was a problem hiding this comment.
@flkasper thanks for the update. I'll have a look.
+ add/fix of router-link on createdAt column in frosh-mail-archive-index.twig + add missing positionIdentifier to card in frosh-mail-resend-history.html.twig
flkasper
force-pushed
the
feature/filter-last-history-mail-transport-state
branch
from
6961ea8
to
c0ce059
Compare
|
@flkasper this PR sparked a discussion about the way mails are stored in the database. We came to the conclusion that the table structure needs some work. I will be doing some major changes in the near future. We will most likely introduce an additional table to track "resends". Therefore I will have to close this PR for the moment. Thank you very much for the time and effort. |
Follow up feature from PR #84