fix: Attachments show up correctly again now #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schneider-felix
force-pushed
the
fix-attachments
branch
2 times, most recently
from
3ac50a1
to
8f9a9fb
Compare
schneider-felix
force-pushed
the
fix-attachments
branch
from
8f9a9fb
to
6a4177e
Compare
schneider-felix
force-pushed
the
fix-attachments
branch
from
eb9f908
to
ee9e7ef
Compare
|
@schneider-felix It would be desirable if the change were also integrated in 2.x. Shopware 6.5 is still used quite frequently. |
@flkasper Sure, I will backport this to the 2.x branch, after @tinect or @shyim had the chance to review this change. |
tinect
reviewed
Oct 9, 2024
|
This might also solve #93 The BCC recipient set in the MailSender should be considered with this change. https://github.com/shopware/shopware/blob/trunk/src/Core/Content/Mail/Service/MailSender.php#L49 |
shyim
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #88
Because of the way Shopware handles attachments, the attachments are not resolved before the MailTransport has run. That's why we need to save attachments in the Subscriber.
While I was at it I also improved the UI of attachments.
