Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make build:schema script self-sufficient #3222

Merged
merged 5 commits into from
Sep 27, 2024
Merged

chore: make build:schema script self-sufficient #3222

merged 5 commits into from
Sep 27, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Sep 27, 2024 •
edited by fuel-service-user
Loading

Summary

The build:schema script now starts and kills its own node, thereby not depending on a node running on port 4000.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@nedsalk nedsalk added the chore Issue is a chore label Sep 27, 2024
@nedsalk nedsalk self-assigned this Sep 27, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 27, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:30am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:30am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 27, 2024 0:30am

arboleya
arboleya approved these changes Sep 27, 2024
View reviewed changes
.changeset/serious-crabs-begin.md Show resolved Hide resolved
@nedsalk nedsalk enabled auto-merge (squash) September 27, 2024 12:24
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.35%(-0.03%) 71.61%(+0%) 75.49%(+0%) 76.5%(-0.04%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 ✨ packages/account/scripts/generate-fuel-core-schema.mts 0%
(+0%)		 100%
(+100%)		 100%
(+100%)		 0%
(+0%)

@nedsalk nedsalk merged commit 502c89e into master Sep 27, 2024
24 checks passed
@nedsalk nedsalk deleted the ns/chore/fuel-core-schema-gen-improvement branch September 27, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhaiwat10 Dhaiwat10 Dhaiwat10 approved these changes

@Torres-ssf Torres-ssf Torres-ssf approved these changes

@danielbate danielbate danielbate approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

Assignees

@nedsalk nedsalk

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the build:schema script to be isolated
5 participants
@nedsalk @arboleya @danielbate @Torres-ssf @Dhaiwat10