chore: filter demo projects from packages #3276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #3276 will not alter performanceComparing Summary
|
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
arboleya
reviewed
Oct 8, 2024
| @@ -12,7 +12,7 @@ | |||
| "scripts": { | |||
| "dev": "nodemon --config nodemon.config.json -x 'pnpm build:packages'", | |||
| "build": "turbo run build --cache-dir=.turbo", | |||
| "build:packages": "turbo run build --filter=!docs --filter=!template-*", | |||
| "build:packages": "turbo run build --filter=!docs --filter=!template-* --filter=!demo-*", | |||
There was a problem hiding this comment.
Demos were made to serve as test/validators.
There was a problem hiding this comment.
Demos were made to serve as test/validators.
@arboleya I suppose I thought the build:packages command should only be responsible for building the packages.
Then the build command would be build + validate as you say.
Thoughts?
petertonysmith94
changed the title
|
Closing as no planned |
petertonysmith94
deleted the
ps/chore/filter-demo-projects-from-packages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
demoapplication builds for thebuild:packagescommand.Checklist