Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge chain and nodeInfo queries into one #3284

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

nedsalk
Copy link
Contributor

@nedsalk nedsalk commented Oct 9, 2024

Summary

This PR adds a new getChainAndNodeInfo query which returns the chain and nodeInfo data in one request, as opposed to the way we've been doing up until now where we've been sending them separately.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 10:22am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 10:22am

@nedsalk nedsalk marked this pull request as ready for review October 9, 2024 07:31
@nedsalk nedsalk changed the title Ns/chore/merge chain and node info query chore: merge chain and nodeInfo query into one Oct 9, 2024
@github-actions github-actions bot added the chore Issue is a chore label Oct 9, 2024
@nedsalk nedsalk changed the title chore: merge chain and nodeInfo query into one chore: merge chain and nodeInfo queries into one Oct 9, 2024
Copy link

codspeed-hq bot commented Oct 9, 2024

CodSpeed Performance Report

Merging #3284 will not alter performance

Comparing ns/chore/merge-chain-and-node-info-query (4b51908) with master (c84abb3)

Summary

✅ 18 untouched benchmarks

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Coverage Report:

Lines Branches Functions Statements
76.18%(-0.1%) 70.27%(-0.02%) 75.11%(-0.15%) 76.31%(-0.09%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/provider.ts 69.66%
(-1.7%)
63.81%
(-0.36%)
71.73%
(-2.18%)
69.35%
(-1.64%)
🔴 packages/account/src/providers/generated/operations.ts 95.07%
(-0.64%)
100%
(+0%)
84.78%
(-1.88%)
95.48%
(-0.59%)

@nedsalk nedsalk enabled auto-merge (squash) October 9, 2024 16:13
@nedsalk nedsalk merged commit 74991ad into master Oct 9, 2024
24 checks passed
@nedsalk nedsalk deleted the ns/chore/merge-chain-and-node-info-query branch October 9, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants