Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix markdown lint check #3430

Merged
merged 18 commits into from
Dec 2, 2024
Merged

chore: fix markdown lint check #3430

merged 18 commits into from
Dec 2, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Nov 28, 2024 •
edited
Loading

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf self-assigned this Nov 28, 2024
@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 11:37am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 11:37am
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 11:37am

@Torres-ssf Torres-ssf added bug Issue is a bug chore Issue is a chore and removed chore Issue is a chore labels Nov 28, 2024
@github-actions github-actions bot added the chore Issue is a chore label Nov 28, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 28, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #3430 will not alter performance

Comparing st/chore/fix-ci-markdown-lint-check (b268534) with master (ef94263)

Summary

✅ 18 untouched benchmarks

@Torres-ssf
Copy link
Contributor Author

This is one example of a failing CI for dead links

https://github.com/FuelLabs/fuels-ts/actions/runs/12073895842/job/33670915238#step:10:14

@Torres-ssf Torres-ssf marked this pull request as ready for review November 29, 2024 00:30
petertonysmith94
petertonysmith94 reviewed Nov 29, 2024
View reviewed changes
link-check.config.json Outdated Show resolved Hide resolved
scripts/lint-md-links.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.46%(+0%) 69.94%(-0.03%) 74.46%(+0%) 76.44%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 76.71%
(-1.37%)		 84%
(+0%)		 88.81%
(+0%)

maschad
maschad approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Torres-ssf I am sure you have saved at least 1000 hours of dev time with this fix! 🥳 Awesome work 🚀

@Torres-ssf Torres-ssf merged commit cb3a31a into master Dec 2, 2024
25 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/fix-ci-markdown-lint-check branch December 2, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petertonysmith94 petertonysmith94 petertonysmith94 approved these changes

@maschad maschad maschad approved these changes

@danielbate danielbate danielbate approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@nedsalk nedsalk Awaiting requested review from nedsalk nedsalk is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
bug Issue is a bug chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flaky markdown link linter
4 participants
@Torres-ssf @danielbate @maschad @petertonysmith94