Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add blob cost optimizations #3434

Closed
wants to merge 3 commits into from
Closed

Conversation

maschad
Copy link
Member

@maschad maschad commented Nov 29, 2024

Release notes

In this release, we:

  • We deprecated the chunkSizeMultiplier option as we now calculate that on behalf of the consumer
  • Optimized blob uploads to reduce failures and provide more accurate cost estimations

Summary

Optimizes blob uploads by calculating an optimal cost based on transaction size limit, blob size and account balance. Also adds retries for failures based on gas spikes.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@maschad maschad self-assigned this Nov 29, 2024
Copy link

vercel bot commented Nov 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 10:39pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 10:39pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2024 10:39pm

Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
76.32%(-0.14%) 69.83%(-0.14%) 74.42%(-0.04%) 76.3%(-0.14%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/contract/src/contract-factory.ts 29.48%
(-3.37%)
26.08%
(-2.49%)
30.76%
(-1.24%)
28.75%
(-3.19%)

Copy link

codspeed-hq bot commented Nov 29, 2024

CodSpeed Performance Report

Merging #3434 will degrade performances by 94.88%

Comparing mc/chore/blob-optimisations (28471fd) with master (ef94263)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master mc/chore/blob-optimisations Change
should successfully execute a contract deploy as blobs 3.7 s 72.2 s -94.88%

@maschad
Copy link
Member Author

maschad commented Dec 2, 2024

Given that although this may be ultimately improve gas costs, they don't outweigh the performance degradations introduced by trying to find an optimal cost, so I am closing this PR.

@maschad maschad closed this Dec 2, 2024
@arboleya arboleya deleted the mc/chore/blob-optimisations branch December 2, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blob upload optimisations
1 participant