Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add max outputs documentation to combining UTXO docs #3435

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

maschad
Copy link
Member

@maschad maschad commented Nov 30, 2024

Summary

Merely added a section about maxOutputs to the Combining UTXOs docs

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

Copy link

vercel bot commented Nov 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 6:16pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 6:16pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2024 6:16pm

@github-actions github-actions bot added the docs Requests pertinent to documentation label Nov 30, 2024
Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #3435 will not alter performance

Comparing mc/docs/add-docs-around-utxo-splitting (799cedb) with master (ef94263)

Summary

✅ 18 untouched benchmarks

Copy link
Contributor

github-actions bot commented Dec 1, 2024

Coverage Report:

Lines Branches Functions Statements
76.46%(+0%) 69.97%(+0%) 74.46%(+0%) 76.44%(+0%)
Changed Files:

Coverage values did not change👌.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worthwhile separating the snippet into 2, one for separation and another for combination?


## Max Outputs

It's also important to note that depending on the chain configuration, you may be limited on the number of outputs you can have in a transaction. This amount can be queried via the [TxParameters](https://docs.fuel.network/docs/graphql/reference/objects/#txparameters) GraphQL query
Copy link
Contributor

@petertonysmith94 petertonysmith94 Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The user could be limited on both the inputs and outputs depending on the operation.

Would it be worthwhile showing how to query these with the TS SDK:

const { maxInputs, maxOutputs } = provider.getChain().consensusParameters.txParameters;

---
---

docs: add max outputs documentation to combining UTXO docs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be closing #3429, looks like it should just be related to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Requests pertinent to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs around UTXO dismantling/consolidation
3 participants