Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable fuel-core node cleanup to work in Bun #3438

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Dec 1, 2024

Release notes

In this release, we:

  • Fixed issue with fuel-core node cleanup operation failing in Bun.

Summary

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@petertonysmith94 petertonysmith94 added the bug Issue is a bug label Dec 1, 2024
@petertonysmith94 petertonysmith94 self-assigned this Dec 1, 2024
Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:31pm
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:31pm
ts-docs-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:31pm

Copy link
Contributor

github-actions bot commented Dec 1, 2024

This PR is published in NPM with version 0.0.0-pr-3438-20241201211716

Copy link

codspeed-hq bot commented Dec 1, 2024

CodSpeed Performance Report

Merging #3438 will degrade performances by 36.94%

Comparing ps/fix/kill-launch-test-node-for-bun (10df16f) with master (283a684)

Summary

❌ 1 regressions
✅ 17 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master ps/fix/kill-launch-test-node-for-bun Change
should successfully transfer a single asset between wallets (x20 times) 62.7 ms 99.4 ms -36.94%

Copy link
Member

@arboleya arboleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@petertonysmith94 petertonysmith94 enabled auto-merge (squash) December 2, 2024 13:22
Copy link
Contributor

github-actions bot commented Dec 2, 2024

Coverage Report:

Lines Branches Functions Statements
76.42%(+0.01%) 69.96%(-0.01%) 74.46%(+0%) 76.45%(+0.01%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/test-utils/launchNode.ts 97.11%
(+0.06%)
86.44%
(-1.27%)
100%
(+0%)
97.24%
(+0.05%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fuel-core node cleanup doesn't work in bun
4 participants