Implement backtick syntax for defining commands #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -43,7 +43,7 @@ pub enum TokenKind { | |||
| ReturnKeyword, | |||
|
|
|||
| // Non-zoglin | |||
| CommandBegin, | |||
| CommandBegin(bool), | |||
There was a problem hiding this comment.
Do we need to store this bool in the token? It doesn't seem like it's used anywhere
There was a problem hiding this comment.
It's used in tokenise to determine whether the command literal uses a backtick or is just a keyword command.
There was a problem hiding this comment.
It probably can and should be refactored, but that was the easiest implementation without changing how commands were set to be lexed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #7
Implements backtick syntax, replacing the forward slash syntax.
With this syntax multi-line commands are possible, and the lexer removes excess whitespace
when not within a string inside the command.
This is the first step towards having a command literal, but right now it still requires a newline first.