Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported the URP 10.6.0 patch over to URP 12.1.4 #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OBXS
Copy link

@OBXS OBXS commented Mar 10, 2022

Tested working on Unity 2021.2.13, but should work on Unity 2021.2.9 ~ 13

Edit: I just noticed that the Sample Bias variant on SurfaceInput.hlsl will never be called because ① the Lit.shader that uses SurfaceInput.hlsl doesn't set "_AMD_FSR" as keyword (#pragma multi_compile), and it's never set to be enabled in C#. ② "amd_fsr_mipmap_bias" is never defined as a variable in the shader.

Both of these also appears to be the case for the 10.6.0 patch, was this intentional?

Tested working on Unity 2021.2.13, but should work on Unity 2021.2.9 ~ 13
@abhiavana
Copy link

@OBXS When applying this patch - I get the following error:
error: corrupt patch at line 142

Unity 2021.2.9f1

@OBXS
Copy link
Author

OBXS commented Jun 20, 2022

Huh, that's interesting, I've made sure it worked when I commited it :/
I'll look into it when I have the time. (FSR 2.0's just around the horizon though so no promises)

@ROBYER1
Copy link

ROBYER1 commented Aug 3, 2022

@OBXS When applying this patch - I get the following error: error: corrupt patch at line 142

Unity 2021.2.9f1

Same issue here, did you ever get it working?

@alexArayaYahoo
Copy link

Hi. i did follow the following steps without luck:

  1. I download the zip file, and extracted from it the FSR1.0-For-URP10.6.0-Patch.patch file.
  2. copy the patch file in the C:\urp_test_git\fsr_test\Library\PackageCache directory (i'm not sure if this step is correct)
  3. open on C:\urp_test_git\fsr_test\Library\PackageCache directory a git bash console, and did run the command: git apply FSR1.0-For-URP10.6.0-Patch.patch
  4. the git console dont show me any message, and when i open the project on unity editor i can't find the option to activate fsr on the camera settings ¿ any idea ?

Thanks.

@rocco-haro
Copy link

@OBXS would you recommend ditching this version and exploring how to incorporate v2 into our URP project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants