This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
Domain check function #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -228,6 +229,8 @@ Details: | |||
|
|
|||
| * ``gandi domain create domain.tld`` helps register a domain. Options are ``--domain domain.tld`` for the domain you want to get (/!\ this option is deprecated and will be removed upon next release), ``--duration INTEGER RANGE`` for the registration period, ``--owner TEXT``, ``--admin TEXT``, ``--tech TEXT``, ``--bill TEXT`` for the four contacts to pass to the creation process, ``--nameserver TEXT`` for adding custom nameservers. All these modification can be done as background process using the option ``--background`` (or ``--bg``). | |||
|
|
|||
| * ``gandi domain check omain.tld`` Check information about the specific domain availability and price. | |||
There was a problem hiding this comment.
typo in the command: should be domain.tld.
And it would be more explicit to say Retrieve information.. than Check information...
|
You still need to add a unittest to test this new command, so we can be sure that it works on all python versions. |
|
how? |
|
You can take a look at current tests for domain commands https://github.com/Gandi/gandi.cli/blob/master/gandi/cli/tests/commands/test_domain.py |
When a --vm parameter is used during 'gandi disk create' command the vm's datacenter will be used instead of default or provided datacenter.
|
write unittest |
1 similar comment
|
Hi, i'm need help for search trouble... please |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix