fix secret manager value fetch and lambda memory size

Geekoosh · Jan 2, 2021 · bd69ffd · bd69ffd
1 parent 141446a
commit bd69ffd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/examples/flyway-git/cloudformation/flyway-git.yaml b/examples/flyway-git/cloudformation/flyway-git.yaml
@@ -88,7 +88,7 @@ Resources:
           GIT_REPOSITORY: !Ref GitRepo
           GIT_FOLDERS: !Ref GitFolders
       Handler: com.geekoosh.flyway.FlywayHandler::handleRequest
-      MemorySize: 256
+      MemorySize: 512
       Role: !GetAtt FlywayLambdaExecutionRole.Arn
       Runtime: java8
       Timeout: 120

diff --git a/src/main/java/com/geekoosh/flyway/request/DBRequest.java b/src/main/java/com/geekoosh/flyway/request/DBRequest.java
@@ -45,8 +45,8 @@ public static DBRequest build(DBRequest base) {
         String dbSecret = systemEnvironment.getEnv(SecretVars.DB_SECRET);
         if(dbSecret != null) {
             JSONObject json = ValueManager.latestSecretJson(dbSecret);
-            base.setUsername(json.getString("username"));
-            base.setPassword(json.getString("password"));
+            base.setUsername(json.get("username").toString());
+            base.setPassword(json.get("password").toString());
         } else {
             base.setUsername(ValueManager.value(
                     base.getUsername(), EnvironmentVars.DB_USERNAME

diff --git a/src/main/java/com/geekoosh/flyway/request/GitRequest.java b/src/main/java/com/geekoosh/flyway/request/GitRequest.java
@@ -89,8 +89,8 @@ public static GitRequest build(GitRequest base) {
         String gitSecret = systemEnvironment.getEnv(SecretVars.GIT_SECRET);
         if(gitSecret != null) {
             JSONObject json = ValueManager.latestSecretJson(gitSecret);
-            base.setUsername(json.getString("username"));
-            base.setPassword(json.getString("password"));
+            base.setUsername(json.get("username").toString());
+            base.setPassword(json.get("password").toString());
 
             logger.info("Using secret git variables");
         } else {