Enable jrl-cmakemodules workspace compatiblity #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmastalli
reviewed
Jul 16, 2024
|
@cmastalli Did the modifications are fine to you ? |
I think we should not remove the in #225 (comment). However, I would like to hear from @nim65s on this topic. |
|
@cmastalli I revert the change about add_project_dependency({eigenpy,pinocchio}). If it's fine to you, you can merge. |
|
@cmastalli ping to merge this PR if you are fine. |
Hi @jcarpent -- We're just missing to address this comment: #225 (comment). This should take no time to do it. |
nim65s
approved these changes
Sep 6, 2024
nim65s
added a commit
to nim65s/robotpkg
that referenced
this pull request
Dec 8, 2024
## [4.2.0] - 2024-12-08
### Added
- Add PR2 robots ([210](Gepetto/example-robot-data#210))
- Add GO2 robots ([239](Gepetto/example-robot-data#239))
- Add Falcon Bravo7 Bluevolta robots ([244](Gepetto/example-robot-data#244))
- Add alex robots ([247](Gepetto/example-robot-data#247))
- Add compatibility with jrl-cmakemodules workspace ([225](Gepetto/example-robot-data#225))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.